Modernize typing.Pattern to re.Pattern[str]#162
Merged
Conversation
`typing.Pattern` has been a deprecated alias for `re.Pattern` since Python 3.8. Switch every site in `nielsen/media.py` to the parameterized `re.Pattern[str]` form, which is documentation as well as type; it makes explicit that this project only matches against `str`, never `bytes`. `tests/test_tv.py` already imports `Pattern` from `re`, so no test changes are needed. Drive-by: tidy `# TODO Do not allow non-files` to `# TODO: Do not allow non-files` for consistency with the file's other TODO comments. Resolve #140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typing.Patternhas been a deprecated alias forre.Patternsince Python 3.8. Switch every site innielsen/media.pyto the parameterizedre.Pattern[str]form, which is documentation as well as type; it makes explicit that this project only matches againststr, neverbytes.tests/test_tv.pyalready importsPatternfromre, so no test changes are needed.Drive-by: tidy
# TODO Do not allow non-filesto# TODO: Do not allow non-filesfor consistency with the file's other TODO comments.Resolve #140.