Fix breaking class identity and cast issues#5
Merged
KabanFriends merged 1 commit intoIroriPowered:masterfrom Feb 28, 2026
Merged
Fix breaking class identity and cast issues#5KabanFriends merged 1 commit intoIroriPowered:masterfrom
KabanFriends merged 1 commit intoIroriPowered:masterfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shared runtime dependencies are delegated to the parent app classloader. Without this, Hyinit could load its own duplicate copies of ASM/SpongePowered/mixinextras classes, which breaks class identity and causes cast issues with
IMixinConfigPlugin.Also hardens plugin-class loading for malformed early plugin jars by guarding against
loadLocalClassbeing called with anullclass name. This prevents a null name from reachinggetClassLoadingLockand triggering an NPE path.Type of change
Implementation details
HyinitClassLoaderto addisParentDelegatedchecks inloadClass.org.objectweb.asm.org.spongepowered.asm.com.llamalad7.mixinextras.MixinPluginClassLoaderwith a HEAD mixin injection onloadLocalClassthat:name == nullHyinitLogger)nullearlyConcurrentHashMap.putIfAbsentnull handling crash paths.src/main/java/cc/irori/hyinit/mixin/HyinitClassLoader.javasrc/main/java/cc/irori/hyinit/mixin/impl/MixinPluginClassLoader.javaChecklist
spotlessApplywhen necessary)Additional Info
PR required for Refixes PR associated to it.