Security: Hardcoded Last.fm API secret in default configuration#535
Open
Nam0101 wants to merge 1 commit intoIrosTheBeggar:masterfrom
Open
Conversation
…ration The default config embeds a concrete `lastFM.apiSecret` (and paired API key) directly in source code. Because this repository is public, anyone can reuse these credentials to impersonate this application against Last.fm APIs, consume quota/rate limits, and potentially disrupt legitimate users of the feature. This is a real credential exposure, not a placeholder. Affected files: config.js Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
While going through the codebase, I noticed a minor opportunity for improvement regarding
src/state/config.js.Context:
The default config embeds a concrete
lastFM.apiSecret(and paired API key) directly in source code. Because this repository is public, anyone can reuse these credentials to impersonate this application against Last.fm APIs, consume quota/rate limits, and potentially disrupt legitimate users of the feature. This is a real credential exposure, not a placeholder.Proposed fix:
Remove the hardcoded defaults and load these values from environment variables or user config at runtime. For example:
apiKey: Joi.string().default(process.env.LASTFM_API_KEY || ''),apiSecret: Joi.string().default(process.env.LASTFM_API_SECRET || ''), then enforce non-empty values only when Last.fm integration is enabled. Also rotate/revoke the currently exposed secret with Last.fm.Files touched:
src/state/config.js(modified)(Note: Tested the changes locally to ensure everything works as expected. Let me know if you need any adjustments, happy to help!)
—
NamNV
📍 Hanoi, Vietnam
📧 nam.nv205106@gmail.com