Skip to content

[Task]: Add MWI theme story#120

Open
LagunaElectric wants to merge 10 commits into
Ishadijcks:developfrom
LagunaElectric:feat-add-custom-tailwind-to-histoire
Open

[Task]: Add MWI theme story#120
LagunaElectric wants to merge 10 commits into
Ishadijcks:developfrom
LagunaElectric:feat-add-custom-tailwind-to-histoire

Conversation

@LagunaElectric
Copy link
Copy Markdown
Contributor

Closes #119

@LagunaElectric LagunaElectric marked this pull request as ready for review July 8, 2023 05:04
Comment thread histoire.css
Comment thread package.json
"@vitejs/plugin-vue": "^4.1.0",
"@vueuse/core": "^10.2.1",
"autoprefixer": "^10.4.14",
"floating-vue": "^2.0.0-beta.24",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these two dependencies?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VueUse gives me lots of composables to use in the stories, and floating-vue gives me a tooltip directive. I've added them as dev dependencies, which you said I could go nuts with IIRC.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that Histoire could sync with Tailwind automatically, why do we need to redeclare our tailwind config here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different. Here I'm storing our config as an object so that I can build a display around it. If there is a way to get it programmatically, that would be nice if it works the same way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular file defines the Tailwind story that shows off our config. This way we can take a glance when choosing colors. I also built in a gradient builder :)

@LagunaElectric
Copy link
Copy Markdown
Contributor Author

@Ishadijcks What else is needed here to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task(MDS): Add a story to show off the custom theme colors

2 participants