Refactor message file structure#142
Open
seashairo wants to merge 4 commits into
Open
Conversation
When this change is applied, * the server message type is moved into a messages folder, and the client messages folder also exists in its own subdirectory instead of a subdirectory of server messages. * adds a NoopMessageParser which will log the received message instead of warning about an unhandled message * adds Noop handlers for NewBattle, CombatUnitsInBattleUpdated, CommunityBuffsUpdated, and MarketItemOrderBooksUpdated.
When this change is applied, * the server message type is moved into a messages folder, and the client messages folder also exists in its own subdirectory instead of a subdirectory of server messages. * adds a NoopMessageParser which will log the received message instead of warning about an unhandled message * adds Noop handlers for NewBattle, CombatUnitsInBattleUpdated, CommunityBuffsUpdated, and MarketItemOrderBooksUpdated.
…e into chore/refactor-messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this change is applied,
the server message type is moved into a messages folder, and the
client messages folder also exists in its own subdirectory instead
of a subdirectory of server messages
adds a NoopMessageParser which will log the received message instead
of warning about an unhandled message. This will allow warnings to be
cut down while still keeping track of messages which aren't fully handled,
and also allow some message types to be ignored.
adds Noop handlers for NewBattle, CombatUnitsInBattleUpdated,
CommunityBuffsUpdated, and MarketItemOrderBooksUpdated. This is
just to work towards message completion