Enhancing Plugin#84
Open
AmVoidGuy wants to merge 6 commits into
Open
Conversation
Ishadijcks
requested changes
May 28, 2023
Owner
Ishadijcks
left a comment
Ishadijcks
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Enhancing is quite a math-heavy feature, making it somewhat hard to review. I'm not fully done yet, but I'm leaving some general feedback as well
- Don't use
document.getElementById()and alike. With Vue you can use form bindings to get form data reactively. https://vuejs.org/guide/essentials/forms.html. And don't make the plugin depend on the input, instead pass everything as parameters so we can test the plugin individually from the UI - Whenever you implement a function that is somewhat unrelated to the current feature, consider moving it to
utils/ - Don't hardcode game data if we can get it from the
init_clientmessage. Boost levels and such can all be read from their respective features.
…dings. Added Buffs.ts so that the ConsumableDetail can now grab item buffs from the init client info. Moved some methods to Util helper classes
…d for efficiency to Skills as it can be used for any skill, not just enhancing.
Contributor
|
I love seeing this kind of commit message. Made my day 😂 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly just a lot of math functions brought over and remade from the cowculator and also comparing with the stuff that was in the discord as well to make sure the results made sense. The plugin itself grabs your currently equipped tool and enhancement bonus, allows you to fill in prices and your enhancing goals, and then calculates the average actions / cost / best protect level.