Conversation
|
Hi, I am currently working on improving the code quality. So the PR would be reviewed later. Meanwhile, you are supposed to keep syncing with the latest main branch. (Mainly for performing checks.) Thanks for contributing. |
|
OK, that's great, improving code quality is not easy, thanks for your excellent work ! Should I close this PR and re-pull it ? |
Actually you just need to run As for keeping or closing, it depends on you. |
IsshikiHugh
left a comment
IsshikiHugh
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
I have commented some problems with code quality.
Meanwhile, I think it's better to leverage the benefits of bark's multi-levels notification support.
Currently the logic is totally the same as real-time message APP like DingTalk, wasting the flexibility of the framework, resulting code redundancy.
For bark, I think it can be better to send passive message for exp start, active message for exp finished, timeSensitive/active for error message.
I am not familiar with bark currently, but I think using the plain logic wastes a lot.
|
Thanks for your deliberative review. I've already done problems you referred to. The Multi-Level notification feature for messages of different signals, as you mentioned above, will be added in next version. The format of |
- Implement BarkBackendInfo class for notification parameters - Add BarkNotifierBackend with full API support - Include all Bark features (sound, badges, URLs, etc.) - Add comprehensive unit tests - Document setup in third_party_setup/bark.md Resolves IsshikiHugh#19 # Reference the original PR if applicable
2 participants
Add Bark Backends and docs