Modified definition errors of the pose limits of SKEL model.#51
Open
Daydreamer-f wants to merge 1 commit intoIsshikiHugh:mainfrom
Open
Modified definition errors of the pose limits of SKEL model.#51Daydreamer-f wants to merge 1 commit intoIsshikiHugh:mainfrom
Daydreamer-f wants to merge 1 commit intoIsshikiHugh:mainfrom
Conversation
Owner
|
Thanks for the contribution! Waiting for the progress of MarilynKeller/SKEL#38 . |
IsshikiHugh
added
the
impl details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update selected joint ROM limits. The default SKEL pose limits produce widespread violations on the canonical sample motion (
models/skel_models_v1.1/sample_motion/01_01_poses_skel.pkl). Limits are recalibrated using the sequence’s empirical angle ranges and clinical sources (Physio-pedia: Goniometry—Wrist Radial Deviation; Kenhub: Scapulothoracic joint).