Fix missing space at text concatenation boundaries#81
Open
sniper-noob wants to merge 1 commit into
Open
Conversation
When concatenating begin + generated_middle + end, no space separator
was added. If begin doesn't end with whitespace and generated_middle
doesn't start with one, words fuse together causing label misalignment.
Fix: Add explicit space separators between the three segments.
Example:
begin = "The quick brown fox"
generated_middle = "jumped over the lazy"
end = "dog in the park."
Before (BUG):
"The quick brown foxjumped over the lazydog in the park."
split() -> 10 words, but labels has 12 entries (4+5+3 from each part)
After (FIX):
"The quick brown fox jumped over the lazy dog in the park."
split() -> 12 words, matches labels exactly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When concatenating begin + generated_middle + end, no space separator was added. If begin doesn't end with whitespace and generated_middle doesn't start with one, words fuse together causing label misalignment.
Fix: Add explicit space separators between the three segments.
Example:
begin = "The quick brown fox"
generated_middle = "jumped over the lazy"
end = "dog in the park."
Before (BUG):
"The quick brown foxjumped over the lazydog in the park."
split() -> 10 words, but labels has 12 entries (4+5+3 from each part)
After (FIX):
"The quick brown fox jumped over the lazy dog in the park."
split() -> 12 words, matches labels exactly