Skip to content

created a Chip component#47

Open
cgr28 wants to merge 4 commits into
It-s-Saturday:mainfrom
cgr28:chip
Open

created a Chip component#47
cgr28 wants to merge 4 commits into
It-s-Saturday:mainfrom
cgr28:chip

Conversation

@cgr28
Copy link
Copy Markdown
Member

@cgr28 cgr28 commented Jun 29, 2023

Description

Related Issue

Issue: #43

Screenshots (if appropriate):

Types of changes

  • Bug fix
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Other (please describe)

@cgr28 cgr28 linked an issue Jun 29, 2023 that may be closed by this pull request
@cgr28 cgr28 changed the title Chip created a Chip component Jun 29, 2023
@itsjayway
Copy link
Copy Markdown
Member

itsjayway commented Jun 29, 2023

can you add screenshot(s) to PR description

Comment on lines +4 to +5
export default function Chip(props) {
const { label } = props;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default function Chip(props) {
const { label } = props;
export default function Chip({ label }) {

@@ -0,0 +1,16 @@
import React from 'react';
import PropTypes from 'prop-types';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docstring

@itsjayway
Copy link
Copy Markdown
Member

itsjayway commented Jul 1, 2023

also, mismatch on Request (when a student clicks request) and staff; should both show 3
image

image

@cgr28
Copy link
Copy Markdown
Member Author

cgr28 commented Jul 7, 2023

image
image
image
For some reason, I'm getting different available quantities depending on the page. On request, the available quantity is 6 then on the home and admin pages, it's 0. It's like this for multiple packages also, not just this one.

@itsjayway
Copy link
Copy Markdown
Member

itsjayway commented Jul 10, 2023

For some reason, I'm getting different available quantities depending on the page. On request, the available quantity is 6 then on the home and admin pages, it's 0.

I'm wondering, the logic looks the same; could it be the data that's being used to make the api call? the _id should be passed in between when the package exists within PackageGenerator and when it's being shown standalone

@itsjayway
Copy link
Copy Markdown
Member

also, i believe your fork is out of date and can be synced with latest main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: chip component

2 participants