created a Chip component#47
Open
cgr28 wants to merge 4 commits into
Open
Conversation
Member
|
can you add screenshot(s) to PR description |
itsjayway
requested changes
Jun 29, 2023
Comment on lines
+4
to
+5
| export default function Chip(props) { | ||
| const { label } = props; |
Member
There was a problem hiding this comment.
Suggested change
| export default function Chip(props) { | |
| const { label } = props; | |
| export default function Chip({ label }) { |
| @@ -0,0 +1,16 @@ | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
|
|
|||
Member
Member
Author
Member
I'm wondering, the logic looks the same; could it be the data that's being used to make the api call? the |
Member
|
also, i believe your fork is out of date and can be synced with latest main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Related Issue
Issue: #43
Screenshots (if appropriate):
Types of changes