Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Jan 11, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

Add start session and end session APIs

Testing

  • Run the setup
  • Login and then click on the "Embedded" tab
  • Click "Start session"
  • In the console in Xcode, you should see a message that looks like following:
     	💛 17:26:04.7110:0x60000173fc40:ReactIterableAPI:startEmbeddedSession():500
    
  • Click "End session"
  • In the console in Xcode, you should see a message that looks like following:
    	💛 17:27:13.2810:0x6000017fc140:ReactIterableAPI:endEmbeddedSession():506
    	💛 17:27:13.2820:0x6000017fc140:EmbeddedSessionManager:endSession():42: No impressions in the session. Skipping tracking.
    

Setup

  • cd into root and run yarn install
  • cd into example and run yarn install
  • cd into ios and run bundle exec pod install
  • open two separate terminals.
  • In Terminal 1
    • run watchman watch-del-all
    • run yarn start --reset-cache
  • In Terminal 2
    • cd into ios
    • run open ReactNativeSdkExample.xcworkspace
    • Once Xcode opens the project, choose an emulator then click the play button to run it.

@github-actions
Copy link

Lines Statements Branches Functions
Coverage: 62%
62.72% (392/625) 38.64% (97/251) 61.5% (139/226)

@qltysh
Copy link

qltysh bot commented Jan 11, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds iOS implementations for embedded session management methods (startEmbeddedSession and endEmbeddedSession) to bring iOS to parity with the existing Android implementation. These methods enable tracking of embedded messaging sessions in React Native applications.

Changes:

  • Added Swift methods in ReactIterableAPI.swift that call EmbeddedSessionManager.shared
  • Added Objective-C bridge methods in RNIterableAPI.mm for both new and legacy React Native architectures

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ios/RNIterableAPI/ReactIterableAPI.swift Added startEmbeddedSession() and endEmbeddedSession() methods that delegate to the Iterable SDK's EmbeddedSessionManager
ios/RNIterableAPI/RNIterableAPI.mm Added bridge methods for both new architecture and legacy architecture to expose the Swift methods to JavaScript

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants