-
Notifications
You must be signed in to change notification settings - Fork 0
Bump axe-core from 4.12.1 to 4.13.0 in /sandbox/browser-web-v1 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| "private": true, | ||
| "type": "module", | ||
| "dependencies": { | ||
| "axe-core": "4.12.1", | ||
| "axe-core": "4.13.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 axe-core 4.13.0 changes rule outcomes, which can shift accessibility scores The evaluator counts critical accessibility violations from Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| "playwright": "1.62.0" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Recorded accessibility-tool version no longer matches the version actually used in evaluations
The accessibility checker used by the browser evaluator was upgraded (
"axe-core": "4.13.0"atsandbox/browser-web-v1/package.json:6) without updating the frozen environment record that is stored with every evaluation, so runs are labelled with a version that was not actually used.Impact: Evaluation results are recorded with the wrong accessibility-tool version, breaking reproducibility claims, and the environment consistency check fails.
Frozen environment descriptor drift between package.json and EVALUATION_ENVIRONMENT_V1
lib/domain/ranked-catalog.ts:45still declaresaxeCore: "4.12.1". This descriptor is persisted asevaluationPolicyfor runs (lib/evaluation/frontend.ts:58,lib/data/catalog-admin.ts:312), while the sandbox evaluator imports axe-core fromsandbox/browser-web-v1/package.json(sandbox/browser-web-v1/evaluate.mjs:4), now 4.13.0.tests/security-policy.test.ts:1258-1276asserts the two must match, so the local gate (npm test) required by CONTRIBUTING.md will fail.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.