Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 10 additions & 50 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"tailwindcss": "4.2.1",
"tsx": "^4.23.7",
"typescript": "5.9.3",
"vinext": "0.0.50",
"vinext": "0.2.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 tsconfig path alias resolution may no longer be provided by vinext 0.2.1

In vinext 0.0.50 the core plugin imported vite-tsconfig-paths directly and, for Vite 8, set resolve.tsconfigPaths: true for the project's environments (see dist/index.js:58,382,409,601 of the 0.0.50 tarball). In vinext 0.2.1 the only remaining tsconfig handling is for loading next.config (dist/config/next-config.js:317-328); the plugin no longer registers vite-tsconfig-paths nor enables resolve.tsconfigPaths for application code, and the dependency moved to an optional peer (which is why this PR's lockfile update deletes vite-tsconfig-paths, tsconfck, and globrex). This repo relies heavily on the @/* alias declared only in tsconfig.json (e.g. app/layout.tsx, app/api/**/route.ts) and vite.config.ts declares no resolve.alias and does not add a tsconfigPaths() plugin. Vite 8 exposes resolve.tsconfigPaths as an opt-in boolean (dist/node/index.d.ts:2016), so unless it defaults to enabled, npm run build/npm run dev could fail to resolve @/... imports after this bump. Worth verifying with an actual install + build before merging (node_modules is not present in the checkout, so this could not be exercised here).

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Minor-version bump on a pre-1.0 dependency crosses effectively-breaking boundaries

vinext is pre-1.0 (0.0.50 -> 0.2.1), so minor bumps here can contain breaking changes; the release notes include peer-dependency restructuring (vite-tsconfig-paths becoming an optional peer) and Pages/App Router behavior changes such as reactStrictMode now being enforced by wrapping the client root. The repo's Worker entry imports vinext/server/app-router-entry (worker/index.ts:2), so the full local gate described in CONTRIBUTING.md (build, both Worker dry-runs, preflight) should be run against this bump rather than relying on the compatibility score.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"vite": "^8.2.0",
"wrangler": "^4.115.0"
},
Expand Down
Loading