ci(gates): protect main with quality gates#2
Merged
Conversation
Signed-off-by: Ivan Li <ivanli2048@gmail.com>
9f5c2f3 to
714a153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/quality-gates.jsonas the repo-local source of truth for protectedmaingates.Buildand addmerge_groupsupport.mainwrites; version updates must land as signed PRs before publishing.Verification
python3 -m json.tool .github/quality-gates.jsonpython3 /Users/ivan/.style-playbook-skills/skills/style-topic-quality-gates/scripts/check_quality_gates.py --repo-root . --declaration .github/quality-gates.json --allow-unchecked-branch-protectionpython3YAML parse for.github/workflows/*.ymlgit diff --checkcargo fmt -- --checkcargo clippy --all-targets --all-features -- -D warningscargo testReferences
docs/specs/b7k2m-repo-quality-gates/SPEC.mdREADME.md,.github/quality-gates.jsonNotes
This fixes the root cause that allowed PR #1 to merge: GitHub had no branch protection on
mainand no repository rulesets.