Parameterize mock SMTP namespace in deployment hooks#2
Draft
Ivanmeneges wants to merge 1 commit into
Draft
Conversation
Allow msg-gateways-setup.sh and common-labeling hook to accept a custom Kubernetes namespace for mock SMTP, defaulting to mock-smtp for backward compatibility. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for deploying mock SMTP into a custom Kubernetes namespace per environment, while keeping the default
mock-smtpnamespace for existing deployments.Changes
msg-gateways-setup.shaccepts an optional namespace argument (defaults tomock-smtp)common-labeling-istio-and-sharing-cm-secrets-among-ns.shacceptsSMTP_NAMESPACEenv var or first argumentMotivation
The new
dev0environment deploys mock SMTP into a dedicateddev0-mock-smtpnamespace with hostsmtp.dev0.mosip.net. These hook changes allow each environment branch to specify its own SMTP namespace without duplicating hook scripts.Backward compatibility
Existing environments that do not pass a namespace continue to use
mock-smtpas before.