Issue with FNG-HCPB post-processing#482
Conversation
…giving the wrong result.
WalkthroughRemoved two mass transformation steps from YAML benchmark configuration sections. The deletions simplify data processing pipelines in the "Tritium activity" and "Tritium activity Pellet" sections while preserving all remaining actions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks Jude, tests are failing due to an update of pandas to a major release (3.0). Please do one of the following:
or
|
The mass factor was being accounted for twice as it was contained within the scale factor also. This pull request removes the mass divisor to resolve this issue.
Summary by CodeRabbit