Update/mainscreen - #8
Open
JB184351 wants to merge 47 commits into
Open
Conversation
JB184351
commented
Dec 27, 2024
JB184351
commented
Owner
- Removed PlaylistTrackView
- Made it so that after selecting a playlist we go immediately to the playback screen.
Playcontrols
Fixed the bug when on first ask for Apple Music permissions that the AppleMusicPermission view was still displaying after allowing Apple Music.
I added a default playlist icon for when artwork can't be fetched from a playlist because of a nil value
Removing this for now as we're not using it.
Apple music integration
With this change this gives us HD artwork covers compared to before.
When displaying the time previously, any time less than 10 seconds would display a 0 in front of the seconds no matter how many minutes the song had already been playing.
I fixed a playback issue where the song would start over after each time I would play it and I noticed that I would reset the queue every time I played the button so now I'm only setting the queue upon the first time this view is presented
The end speaker changes based on the current volume of the device
When I was reaching lower volumes I would hit the default value somehow and so just changed it to where it was the lower volume speaker icon in that case.
I noticed that when hitting around the 30 and 60 values that the speaker icon changes to the default value so updating the values to include to finer decimal places
When on the Playback screen the first time the button will same play instead of Resume
I changed it so that when the songTimer is greater than zero that the song timer text will displayer other wise it'll show the time remaining until it starts playing again.
While the music is playing the chair and music images will rotate as if they're dancing.
Improved playbackscreen
I can play from an entire playlist whether shuffled or as is
I changed the buttons here so we can have a back button when entering the PlayBackView
Properly unwrapping a single Track value
Fixed song information display and made sure all music stopped playing when leaving this view.
Able to add music to a playlist but apparently there might be a bug with iOS 18 where not all the music get's added correctly, I changed the version to iOS 16 to use my iPhone 13 Mini to test this theory with.
Despite having issues adding an entire playlist or an array of Track type to the queue, I'm able to just add one song aka Track at a time and will go to the next song.
This doesn't need to be in there because the only time the playbacktime is being changed is when the timerisactive
Playlist play option
Custom timers
I was using the queue before but I had to work around some issues that were happening, the user has to have iOS 18.1 or newer or more accurately anything before 18.0 and anything 18.1 or newer. Which means I'll probably make this app have an iOS 18.1 requirement.
Update/using musicqueue
After the playlist selection, the PlaybackView will automatically appear with the selected playlist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.