Fixes italics: remove config not doing anything#2
Open
Avenred wants to merge 3 commits into
Open
Conversation
Stops using the depricated AnvilInventory and instead AnvilView
Also adds support for <gradient> and other codes in the anvil too
This reverts commit 8bafb69.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also stops using AnvilInventory in favor of AnvilView as AnvilInventory is going to be removed eventually.
This PR fixes the issue the setting
italics: removenot working by checking if this setting is set first, then adding theChatColor.RESETbefore anything else. Seems to fix the issue for me:Closes #1