Update web_request_async_multi.cpp#233
Open
George-Creekbed wants to merge 1 commit into
Open
Conversation
Inside the constructor for the `Request` class, `resolver.async_resolve` captures `this` within a lambda.
However, the `Request` object has not yet been created (function is called inside the constructor), so on exit this will be empty.
This is solved by moving `resolver.async_resolve` to its own function member, which allows the constructor to complete creating a `Request` object.
At this point it's possible to set `n_threads{2}` in main() and have the program run correctly.
Try it on *example.com* as it still accepts simple http requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside the constructor for the
Requestclass,resolver.async_resolvecapturesthiswithin a lambda.However, the
Requestobject has not yet been created (function is called inside the constructor), so on exit this will be empty. This is solved by movingresolver.async_resolveto its own function member, which allows the constructor to complete creating aRequestobject.At this point it's possible to set
n_threads{2}in main() and have the program run correctly.Try it on example.com as it still accepts simple http requests.