Refactor volume knob interaction into explicit controller and normalize mouse behavior#17
Draft
Copilot wants to merge 7 commits into
Draft
Refactor volume knob interaction into explicit controller and normalize mouse behavior#17Copilot wants to merge 7 commits into
Copilot wants to merge 7 commits into
Conversation
Open
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/352e84a2-406e-4012-818a-0e6c047e8304 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/352e84a2-406e-4012-818a-0e6c047e8304 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/352e84a2-406e-4012-818a-0e6c047e8304 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/352e84a2-406e-4012-818a-0e6c047e8304 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/352e84a2-406e-4012-818a-0e6c047e8304 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/352e84a2-406e-4012-818a-0e6c047e8304 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix volume knob behavior for better user experience
Refactor volume knob interaction into explicit controller and normalize mouse behavior
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The volume knob interaction was hard to reason about and felt inconsistent with mouse input. This change makes knob behavior explicit and predictable: click-to-set, drag-to-adjust, release-to-stop.
Interaction model (OOP)
VolumeKnobController(volume_knob.py) to own knob semantics:contains, configurablehit_padding)start_drag,drag,stop_drag)sprite_rotation_degrees)Main loop integration
main.pywith controller calls._apply_volume_from_knob()to avoid duplicated apply logic.UI/UX consistency
Docs + focused coverage
tests/test_volume_knob.py): hit area, immediate click update, drag gating, and rotation mapping.