Add OOP EQ knob controls (Low/Mid/High) using existing knob asset#22
Draft
Copilot wants to merge 3 commits into
Draft
Add OOP EQ knob controls (Low/Mid/High) using existing knob asset#22Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Open
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/4f95b431-4c1b-4659-9712-8dd71bc35047 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JP1Q/MusicPlayer/sessions/4f95b431-4c1b-4659-9712-8dd71bc35047 Co-authored-by: JP1Q <46629197+JP1Q@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add three EQ knob images for mids, highs, and lows
Add OOP EQ knob controls (Low/Mid/High) using existing knob asset
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds three new EQ controls (Low, Mid, High) alongside the existing volume knob, reusing the same knob image and integrating drag-based interaction in the main player UI. The implementation introduces explicit OOP control primitives so knob behavior is clear, reusable, and isolated from rendering/event plumbing.
OOP control model
eq_controls.pywith:KnobControl: pointer hit-testing, angle/value mapping, render angle, label/percent helpers.EqualizerControls: knob collection management + drag lifecycle (begin_drag,drag_to,end_drag).UI + interaction integration
main.pywith four knob instances:volume,low,mid,high.EqualizerControls.volume.pngand per-knob labels/percent values.Audio behavior updates
Docs and focused coverage