Refactor: Fix pylint code quality issues across adiftools package (9.22 → 9.95/10)#8
Draft
Copilot wants to merge 2 commits into
Draft
Refactor: Fix pylint code quality issues across adiftools package (9.22 → 9.95/10)#8Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: JS2IIU-MH <146515386+JS2IIU-MH@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Check for areas needing refactoring in workspace code
Refactor: Fix pylint code quality issues across adiftools package (9.22 → 9.95/10)
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several code quality issues identified by pylint across the package — incorrect exception syntax, missing file encodings, non-idiomatic type checks, and style issues in the graph module.
adiftools.pytry/exceptimport blocks into one; fixed binary-or exception syntax:except (ModuleNotFoundError, ImportError)encoding='utf-8'to allopen()callsis_loadedproperty toreturn len(self.df_adif) > 0_temp_dfsin__init__; removedhasattrguards inread_adi_streamingcallsign.py/gridlocator.pytype(x) is not str→not isinstance(x, str)adifgraph.pyexcept ModuleNotFoundError or ImportError→except (ModuleNotFoundError, ImportError)bar(disallowed name) →bars; unusedfig→_'%d' % int(height)→f'{int(height):d}'from pandas.api.types import PeriodDtypeandimport matplotlib as mplre-import to module top-levelsum([row[band] for band in bands])→ generator expressiontext_rotationcalculation out of loop inmonthly_band_qso💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.