Add hooks: vibestretch (resubmission of #5780 with corrected safety and privacy notes) - #5793
Open
Eliasjunit wants to merge 2 commits into
Open
Add hooks: vibestretch (resubmission of #5780 with corrected safety and privacy notes)#5793Eliasjunit wants to merge 2 commits into
Eliasjunit wants to merge 2 commits into
Conversation
Resubmission of JSONbored#5780 with the two claims that contradicted the shipped plugin rewritten, per review: - safetyNotes no longer says "never modifies your settings" — the optional /vibestretch:statusline skill does edit ~/.claude when the user runs it, and now says so. - privacyNotes no longer says prompt and tool content is "never read" — the script reads the first 4 KB of the payload for session_id, and the note now states that plainly while keeping the retention claim exact. - scriptLanguage corrected from bash to sh, matching the #!/bin/sh shebang. scriptBody is byte-identical to scripts/vibestretch.sh at v0.7.1 (288 lines) and copySnippet to hooks/hooks.json, both verified programmatically. The troubleshooting section now also covers VS Code, whose terminal drops the notification sequence silently.
My scriptBody refresh cut everything between `scriptBody` and `copySnippet`, and three keys lived in that gap. validate-submission-source caught the one it treats as recommended for hooks (`usageSnippet`); the other two would have degraded the listing silently. The block boundary is now the next top-level key rather than a hardcoded field name. scriptBody remains byte-identical to scripts/vibestretch.sh at v0.7.1, verified by extracting it back out of the .mdx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmission of #5780, closed with a review I agree with: two of the entry's own
claims did not survive contact with what the plugin ships. Both are fixed here.
1.
safetyNotes— the statusline skill does edit settingsWas: "Writes nothing outside its own state directory and never modifies your project or your settings."
The hook script's writes really are confined to
$STATE_DIR, but the plugin alsoships
skills/statusline/SKILL.md, and that skill wraps or installs astatusLinecommand under
~/.claude. Opt-in,disable-model-invocation: true, backs upfirst — and still a settings edit. Now stated:
2.
privacyNotes— the payload is read, just not keptWas: "Prompt and tool content is never read. Only timestamps and elapsed seconds are recorded."
The script reads the first 4 KB of the hook payload to pull
session_idout ofit, and on
PostToolUsethat window contains tool input and output. Nothing fromit is retained or transmitted, but "never read" and "never recorded" are not the
same sentence, and on a privacy note the difference is the point. Now stated:
3.
scriptLanguagemetadataCorrected
bash→sh, matching the#!/bin/shshebang and the existing"A POSIX shell" prerequisite.
Provenance
scriptBodyis byte-identical toscripts/vibestretch.shatv0.7.1 (288
lines — four more than in #5780, from a fix released today) and
copySnippetisbyte-identical to
hooks/hooks.json. Both were verified by extracting them backout of the
.mdxand diffing against the repository files, not by eye.The troubleshooting section additionally notes that VS Code's integrated terminal
discards the notification sequence silently — that was the fix in v0.7.1, found
when a tester ran the plugin there.
Thank you for the review; it was specific enough to act on directly.