Add "View background tasks" to Help menu; descriptive quit dialog buttons

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,6 +1,7 @@
 name: "Bug report"
 description: Create a report to help us improve
 type: Bug
+labels: ["status: needs-triage"]
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/suggestion-for-improvement.md

@@ -2,7 +2,7 @@
 name: Suggestion for improvement
 about: Suggest an enhancement
 title: ''
-labels: ''
+labels: 'status: needs-triage'
 type: 'feature'
 assignees: ''
 

.github/workflows/on-issue-comment.yml

@@ -12,8 +12,16 @@ jobs:
       contents: read
       issues: write
     steps:
+      - name: Decline self-assignment of untriaged issues
+        id: untriaged
+        if: "${{ contains(github.event.comment.body, '/assign-me') && contains(github.event.issue.labels.*.name, 'status: needs-triage') }}"
+        run: |
+          gh issue comment "${{ github.event.issue.html_url }}" --body "Hi @${{ github.event.comment.user.login }}, this issue needs triage by a maintainer first. Please wait until the \`status: needs-triage\` label is removed."
+        env:
+          GH_TOKEN: ${{ github.token }}
       - name: Assign the user or unassign stale assignments
         id: assign
+        if: ${{ steps.untriaged.outcome == 'skipped' }}
         uses: takanome-dev/assign-issue-action@fad4b83750f7df31e03c2a42e8f1880b0b4b3573 # edge
         with:
           github_token: '${{ secrets.GH_TOKEN_ASSIGN_ISSUE_ACTION  || github.token }}'

CHANGELOG.md

@@ -12,12 +12,16 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 ### Added
 
 - We added `jabkit git merge-driver`, a Git merge driver that merges `.bib` files semantically. [#16838](https://github.com/JabRef/jabref/pull/16838)
+- We added "Help > View background tasks" and clearer "Quit anyway"/"Keep JabRef open" buttons when quitting during background tasks. [#12706](https://github.com/JabRef/jabref/issues/12706)
 
 ### Changed
 
 ### Fixed
 
+- We re-enabled the [Grobid](https://github.com/grobidOrg/grobid) citation fetcher again. It is now reachable via https. [#16668](https://github.com/JabRef/jabref/issues/16668)
 - We fixed an issue where the AI chat lost its scroll position when switching back to an entry. [#17172](https://github.com/JabRef/jabref/pull/17172)
+- We fixed an issue where pressing "+" in the "File" field with an automatically found file selected opened the "Add file link" dialog instead of linking the selected file. [#16938](https://github.com/JabRef/jabref/pull/16938)
+- We fixed an issue where case-sensitive search (`=!`, `==!`, `=~!`) in linked files ignored the casing and matched text in any casing. [#13048](https://github.com/JabRef/jabref/issues/13048)
 
 ### Removed
 

CONTRIBUTING.md

@@ -83,6 +83,7 @@ One can also add [callouts](https://just-the-docs.github.io/just-the-docs-tests/
 
 Comment on the issue you want to work at with `/assign-me`.
 GitHub will then automatically assign you.
+Issues labeled `status: needs-triage` cannot be self-assigned until a maintainer has triaged them.
 
 Before you do so, read the complete issue and its discussion.
 Some issues state a prerequisite - typically another pull request that has to be merged first.

build-logic/build.gradle.kts

@@ -28,9 +28,9 @@ dependencies {
     implementation("org.gradlex:java-module-testing:1.8.1")
     implementation("org.gradlex:jvm-dependency-conflict-resolution:2.5")
     implementation("org.gradle.toolchains:foojay-resolver:1.0.0")
-    implementation("org.itsallcode:openfasttrace-gradle:3.2.0")
-    implementation("org.itsallcode.openfasttrace:openfasttrace-api:4.9.0")
-    implementation("org.itsallcode.openfasttrace:openfasttrace-core:4.9.0")
-    implementation("org.itsallcode.openfasttrace:openfasttrace-exporter-specobject:4.9.0")
-    implementation("org.itsallcode.openfasttrace:openfasttrace:4.9.0")
+    implementation("org.itsallcode:openfasttrace-gradle:3.4.0")
+    implementation("org.itsallcode.openfasttrace:openfasttrace-api:4.10.0")
+    implementation("org.itsallcode.openfasttrace:openfasttrace-core:4.10.0")
+    implementation("org.itsallcode.openfasttrace:openfasttrace-exporter-specobject:4.10.0")
+    implementation("org.itsallcode.openfasttrace:openfasttrace:4.10.0")
 }

build-logic/src/main/kotlin/org.jabref.gradle.feature.requirementtracing.gradle.kts

@@ -1,107 +1,3 @@
-import java.io.File
-import java.util.Locale
-
-import org.gradle.api.Project
-import org.gradle.api.plugins.ExtensionAware
-import org.gradle.kotlin.dsl.getByType
-import org.gradle.kotlin.dsl.register
-import org.itsallcode.openfasttrace.api.core.ItemStatus
-import org.itsallcode.openfasttrace.gradle.config.TagPathConfiguration
-import org.itsallcode.openfasttrace.gradle.config.TracingConfig
-import org.itsallcode.openfasttrace.gradle.task.CollectTask
-import org.itsallcode.openfasttrace.gradle.task.TraceTask
-import org.itsallcode.openfasttrace.gradle.task.config.SerializableTagPathConfig
-
-val taskGroupName = "trace"
-val requirementConfigName = "oftRequirementConfig"
-
-allprojects {
-    val tracingConfig = extensions.create("requirementTracing", TracingConfig::class.java, project)
-    (tracingConfig as ExtensionAware).extensions.create("tags", TagPathConfiguration::class.java, project)
-}
-
-gradle.projectsEvaluated {
-    val collectTask = tasks.register<CollectTask>("collectRequirements") {
-        group = taskGroupName
-        description = "Collect requirements and generate specobject file"
-        inputDirectories.set(getAllInputDirectories(rootProject.allprojects))
-        outputFile.set(rootProject.layout.buildDirectory.file("reports/requirements.xml"))
-        pathConfig.set(getPathConfig(rootProject.allprojects))
-    }
-
-    tasks.register<TraceTask>("traceRequirements") {
-        group = taskGroupName
-        description = "Trace requirements and generate tracing report"
-        dependsOn(collectTask)
-
-        val tracingConfig = rootProject.getTracingConfig()
-        failBuild.set(tracingConfig.failBuild)
-        requirementsFile.set(collectTask.flatMap { task -> task.outputFile })
-
-        if (tracingConfig.reportFile.isPresent) {
-            outputFile.set(tracingConfig.reportFile)
-        } else {
-            val extension = if (tracingConfig.reportFormat.get() == "html") "html" else "txt"
-            outputFile.set(rootProject.layout.buildDirectory.file("reports/tracing.$extension"))
-        }
-
-        reportVerbosity.set(tracingConfig.reportVerbosity)
-        reportFormat.set(tracingConfig.reportFormat)
-        importedRequirements.set(getImportedRequirements(rootProject.allprojects))
-        filteredArtifactTypes.set(tracingConfig.filteredArtifactTypes)
-        filteredTags.set(tracingConfig.filteredTags)
-        filterAcceptsItemsWithoutTag.set(tracingConfig.filterAcceptsItemsWithoutTag)
-        filterWantedStatuses.set(getWantedStatuses(tracingConfig))
-        detailsSectionDisplay.set(tracingConfig.detailsSectionDisplay)
-    }
-}
-
-fun Project.getTracingConfig(): TracingConfig = extensions.getByType()
-
-fun getAllInputDirectories(allProjects: Set<Project>): Set<File> = allProjects
-    .flatMap { project -> project.getTracingConfig().inputDirectories.files }
-    .toSet()
-
-fun getImportedRequirements(allProjects: Set<Project>): Set<File> = allProjects
-    .flatMap(::getImportedRequirements)
-    .toSet()
-
-fun getImportedRequirements(project: Project): Set<File> {
-    val importedRequirements = project.getTracingConfig().importedRequirements.orNull.orEmpty()
-    if (importedRequirements.isEmpty()) {
-        return emptySet()
-    }
-
-    val configuration = project.configurations.findByName(requirementConfigName)
-        ?: project.configurations.create(requirementConfigName)
-
-    importedRequirements.forEach { dependency ->
-        project.dependencies.add(requirementConfigName, dependency)
-    }
-
-    return configuration.files
-}
-
-fun getPathConfig(allProjects: Set<Project>): List<SerializableTagPathConfig> = allProjects
-    .mapNotNull(::getTagPathConfig)
-
-fun getTagPathConfig(project: Project): SerializableTagPathConfig? {
-    val tagPathConfig = project.getTracingConfig().tagPathConfig
-    if (tagPathConfig.pathConfig.isEmpty()) {
-        return null
-    }
-    return SerializableTagPathConfig(tagPathConfig)
-}
-
-fun getWantedStatuses(tracingConfig: TracingConfig): Set<ItemStatus> =
-    tracingConfig.filterWantedStatuses.getOrElse(emptySet()).map(::convertStatus).toSet()
-
-fun convertStatus(value: String): ItemStatus = try {
-    ItemStatus.valueOf(value.uppercase(Locale.ROOT))
-} catch (exception: IllegalArgumentException) {
-    val validStatuses = ItemStatus.values().joinToString(", ") { status -> status.name }
-    throw IllegalArgumentException(
-        "Invalid status '$value'. Valid statuses are: $validStatuses",
-        exception,
-    )
+plugins {
+    id("org.itsallcode.openfasttrace")
 }