Skip to content

Rename "Create backup" preference to "Create backups" #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koppor wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rename "Create backup" preference to "Create backups" #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53d5fd7
Rename "Create backup" preference to "Create backups"
koppor Sep 23, 2026
1755d74
Add CHANGELOG entry
koppor Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Changed

- We renamed the preference "Create backup" to "Create backups", because JabRef keeps multiple backup versions. [#780](https://github.com/JabRef/jabref-koppor/pull/780)

### Fixed

- We re-enabled the [Grobid](https://github.com/grobidOrg/grobid) citation fetcher again. It is now reachable via https. [#16668](https://github.com/JabRef/jabref/issues/16668)
Expand Down
2 changes: 1 addition & 1 deletion jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ private void buildView() {
.checkbox(Localization.lang("Always reformat library on save and export"), viewModel.alwaysReformatBibProperty())
.checkbox(Localization.lang("Autosave local libraries"), viewModel.autosaveLocalLibrariesProperty(),
autosave -> autosave.help(HelpFile.AUTOSAVE))
.checkWithField(Localization.lang("Create backup"), viewModel.createBackupProperty(),
.checkWithField(Localization.lang("Create backups"), viewModel.createBackupProperty(),
Comment thread
qodo-free-for-open-source-projects[bot] marked this conversation as resolved.

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Sep 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Translated settings lose their label 🐞 Bug ≡ Correctness

GeneralTab.buildView() now requests the Create backups localization key, while the non-English
bundles still define only Create backup. When a non-English locale is active, the missing lookup
falls back to the English key text instead of the translated label, affecting the General
preferences checkbox.
Agent Prompt 
## Issue description
The preferences UI now looks up `Create backups`, but the localized property files still contain the old `Create backup` key. Non-English users therefore receive the untranslated fallback text instead of their localized backup label.

## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java[126-126]
- jablib/src/main/resources/l10n/JabRef_*.properties[1-9999]

## Recommended Fix
Rename the corresponding `Create backup` entry to `Create backups` in every localization bundle, preserving each existing translation and ensuring the new key is available for all supported locales.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@koppor koppor Sep 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated with Claude Code

Not done: only JabRef_en.properties lives here; other bundles come from Crowdin, English fallback intended.

viewModel.backupDirectoryProperty(),
directory -> directory
.grow()
Expand Down
2 changes: 1 addition & 1 deletion jablib/src/main/resources/l10n/JabRef_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2987,7 +2987,7 @@ Search\ from\ history...=Search from history...
your\ search\ history\ is\ empty=your search history is empty
Clear\ history=Clear history

Create\ backup=Create backup
Create\ backups=Create backups
Experimental\ search\ (Postgres)=Experimental search (Postgres)
Automatically\ search\ and\ show\ unlinked\ files\ in\ the\ entry\ editor=Automatically search and show unlinked files in the entry editor

Expand Down
Loading