fix: retry transient get_entities failures during observation - #413
Open
JackHopkins wants to merge 2 commits into
Open
fix: retry transient get_entities failures during observation#413JackHopkins wants to merge 2 commits into
JackHopkins wants to merge 2 commits into
Conversation
A single transient get_entities failure (engine busy, RCON hiccup) killed an entire multi-hour eval: one rollout errored ~1h in and fail-on-error cancelled the other three healthy epochs. The action sequence replayed clean, confirming the failure was transient. Retry up to 3 times with short backoff, and include the underlying error in the raised message — the previous wrapper discarded it, making the failure undiagnosable from the eval log.
score() after a step could fail transiently (e.g. KeyError 'player' from a corrupted RCON response) and kill the epoch. Apply the same retry-with-backoff used for get_entities, via a shared _call_with_retry helper used by both sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During a 4-node, 64-step eval, one rollout died ~1h in with "Error getting observation: Error getting entities while getting observation" and --fail-on-error cancelled the other three healthy epochs. Two compounding issues:
Fix
Verification