Fix app quitting when opening the first document from the Open dialog#1
Open
bganesh wants to merge 1 commit intoJackYoung27:mainfrom
Open
Fix app quitting when opening the first document from the Open dialog#1bganesh wants to merge 1 commit intoJackYoung27:mainfrom
bganesh wants to merge 1 commit intoJackYoung27:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the app was launched without an initial document, it immediately presented the Open dialog. After selecting a file, the dialog closed before the preview window was created. Because
the app was configured to terminate after the last window closed, AppKit could treat the closed Open dialog as leaving the app with no visible windows and quit before the selected
document opened.
This changes the app lifecycle so closing the last document window no longer terminates the app. It also removes the explicit termination path when the initial Open dialog is cancelled.
With this behavior, the app can remain open without any document windows, and opening the first document from the Open dialog works the same way as opening subsequent documents or opening
files via Finder drag/drop.
Fixes #6