fix(tsfile): install tsfile only in py3.14 CI and add Hub example#4
Merged
Merged
Conversation
tsfile requires pyarrow<20 for python<3.14, which conflicts with datasets' pyarrow>=21.0.0. Remove tsfile from the 'tests' extra in setup.py and install it only in the test_py314 CI job. Guard test_tsfile.py with pytest.importorskip so the module is skipped (at collection time) when tsfile is not installed. Also add a Hub example (tsfile/lotsa_data) to the TsFile loading guide.
JackieTien97
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses @lhoestq's review on huggingface#8160.
tsfilerequirespyarrow<20forpython<3.14, which conflicts withdatasets'
pyarrow>=21.0.0. So:tsfile>=2.3.0from thetestsextra insetup.py.tsfileonly in thetest_py314CI job.tests/packaged_modules/test_tsfile.pywithpytest.importorskip("tsfile")so the module is skipped at collection time when tsfile is not installed.
Also adds a Hub example (
tsfile/lotsa_data) to the TsFile loading guide,as requested. Verified locally:
load_dataset("tsfile/lotsa_data")loads91 device rows.
Self-tested locally (python 3.12)
ruff check+ruff format --check: passed