fix(markdown-lint): exclude CHANGELOG.md from lint globs#240
Merged
JacobPEvans merged 1 commit intomainfrom Apr 26, 2026
Merged
fix(markdown-lint): exclude CHANGELOG.md from lint globs#240JacobPEvans merged 1 commit intomainfrom
JacobPEvans merged 1 commit intomainfrom
Conversation
release-please generates CHANGELOG.md with long GitHub PR URLs that exceed MD013 limits, and double blank lines between sections that trigger MD012. Both are structural artifacts of release-please format (googleapis/release-please#2085, closed won't-fix). ignorePatterns and per-file overrides in config are not applied when the action passes explicit globs — the only reliable mechanism is a negative glob entry. (claude)
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reusable markdownlint workflow to reliably exclude CHANGELOG.md from linting, preventing known release-please-generated formatting from failing markdownlint checks.
Changes:
- Add a negative glob (
!CHANGELOG.md) to the markdownlint-cli2-actionglobsinput to exclude the generated changelog file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!CHANGELOG.mdto the markdownlint glob patterns in_markdown-lint.ymlWhy
release-pleasegenerates CHANGELOG.md with long GitHub PR URLs (MD013 violations) and double blank lines between section headers (MD012 violations). This is by design and won't be fixed upstream (googleapis/release-please#2085, closed won't-fix).ignorePatternsin the config and per-fileoverridesare not respected when the action passes explicit globs — a negative glob entry is the only reliable exclusion mechanism.Test Plan
mlx-benchmarksPR Epic: Comprehensive PR Automation #24 (chore(main): release 0.5.0) CI passes after this merges🤖 Generated with Claude Code