fix(release-please): handle label-race gracefully with error guard#241
Open
JacobPEvans wants to merge 2 commits intomainfrom
Open
fix(release-please): handle label-race gracefully with error guard#241JacobPEvans wants to merge 2 commits intomainfrom
JacobPEvans wants to merge 2 commits intomainfrom
Conversation
…-error The googleapis/release-please-action@v5 step opens the release PR successfully but then immediately tries to apply `autorelease: pending` via GraphQL. The PR's global node ID hasn't propagated yet at that point, so GitHub returns "Could not resolve to a node" — failing the job even though the PR was created correctly. Adding `continue-on-error: true` lets the downstream `Find release PR number` step discover the PR via REST and continue normally. The missing label is cosmetic; release-please re-applies it on the next run. (claude)
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reusable release-please workflow to avoid failing the entire job when googleapis/release-please-action@v5 intermittently errors while applying the autorelease: pending label.
Changes:
- Add
continue-on-error: trueto thegoogleapis/release-please-action@v5step. - Add an explanatory comment describing the label-application race condition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
continue-on-error masks all release-please failures, not just the transient label-application race. Add a guard step that re-fails the job when the release step errored AND the downstream REST lookup finds no release PR — distinguishing a genuine auth/config/API failure from the harmless race. (claude)
JacobPEvans
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition where
googleapis/release-please-action@v5fails with "Could not resolve to a node" when applying theautorelease: pendinglabel immediately after PR creation (the PR's node ID hasn't propagated yet). The fix tolerates the initial failure and adds a guard step that re-fails only on genuine errors (auth, config, API issues).Changes
.github/workflows/_release-please.yml:continue-on-error: trueto the release-please step with explanatory commentTest Plan
Related: #234
🤖 Generated with Claude Code