fix(cache): invalidate map cache on dirty working tree changes#3
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(cache): invalidate map cache on dirty working tree changes#3cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
git_commit_key() used only a hash of directory paths for dirty repos, so ctx map returned stale output after uncommitted edits. Include git status --porcelain in the dirty key (with HEAD SHA) so the cache invalidates on any working-tree change. Co-authored-by: Jaime Basso <JaimeJunr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
ctx mapcould return stale repository maps while developing with uncommitted changes. After the first run on a dirty repo, subsequent edits did not invalidate the map-level cache, so agents received outdated signatures/ranking until the repo was committed or--no-cachewas used.Root cause
git_commit_key()returned a stabledirty-<hash>derived only from the scan directory paths when the working tree was dirty. The commit message claimed mtime-based invalidation, but porcelain/status was never incorporated—so the map cache key stayed constant across edits.Fix
For dirty git repos, the cache key is now
dirty-<HEAD>-<hash(git status --porcelain)>, invalidating whenever the working tree changes. Clean repos still use the HEAD SHA.Validation
test_git_commit_key_dirty_changes_with_working_treecargo test --lib cache::— 6 passedcargo test --locked— full suite passed