Develop#46
Merged
Merged
Conversation
Jamalludeen
commented
Jun 6, 2026
Jamalludeen
left a comment
Owner
Author
There was a problem hiding this comment.
Issue #45 is covered
There was a problem hiding this comment.
Pull request overview
This PR polishes the port-scanner project’s developer/user-facing ergonomics by improving documentation/help text and making a small refactor to centralize scan timeout clamping.
Changes:
- Add a module docstring to the test runner and add type hints to CLI entrypoint functions.
- Document scan cancellation (Stop button) in both the README and in-app help dialog.
- Introduce a
MIN_TIMEOUTconstant and use it to clamp scan timeouts consistently.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| run_tests.py | Adds a top-level docstring describing the test runner wrapper. |
| README.md | Documents that long scans can be cancelled using Stop. |
| portscanner/scanner.py | Centralizes minimum timeout logic via MIN_TIMEOUT constant. |
| portscanner/gui.py | Updates the help dialog text to mention cancelling via Stop. |
| main.py | Adds return type hints to build_parser and main. |
Comments suppressed due to low confidence (1)
portscanner/scanner.py:49
- The triple-quoted string inside
PortScanneris not acting as a class docstring because it is placed after class attributes (MIN_TIMEOUT, etc.). This leaves an unused string literal in the class body and meansPortScanner.__doc__won’t reflect the intended documentation.
MAX_PORTS_PER_SCAN = 4096
# Keep accidental scans bounded so the GUI stays responsive.
RANGE_LIMIT_MESSAGE = " Scan aborted: range exceeds {limit} ports.\n"
"""Controller for scanning port ranges with callbacks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.