Develop#48
Merged
Merged
Conversation
Jamalludeen
commented
Jun 7, 2026
Jamalludeen
left a comment
Jamalludeen
left a comment
Owner
Author
There was a problem hiding this comment.
Issue #47 is covered.
There was a problem hiding this comment.
Pull request overview
This PR makes small usability and maintainability updates across the port scanner app and its tooling, including test coverage for package exports and minor refactors to argument parsing and GUI clipboard handling.
Changes:
- Extend the test runner CLI parsing to support
--pattern <value>in addition to--pattern=<value>. - Refactor/centralize a couple of constants and helpers (scanner connect timeout constant; GUI clipboard helper usage).
- Strengthen package export tests by asserting the expected
APP_NAMEvalue.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_package.py | Adds an explicit assertion for the exported APP_NAME constant. |
| run_tests.py | Updates argv parsing to handle --pattern <value>. |
| portscanner/scanner.py | Introduces a module-level default connect timeout constant and uses it as the default parameter. |
| portscanner/gui.py | Uses the shared copy_to_clipboard helper for copying the license text. |
| main.py | Refactors parser usage so --version parsing occurs before GUI initialization (clarifies intent). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+22
| elif arg == "--pattern": | ||
| pattern = next(argv_iter, None) |
Jamalludeen
commented
Jun 7, 2026
Jamalludeen
left a comment
Jamalludeen
left a comment
Owner
Author
There was a problem hiding this comment.
Changes are safe and confirmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.