show pointer offset notes in the requirements view#642
Open
gdeOo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to use the pointer offset feature in code notes that allows to toolkit to display notes on AddAddress chains.
I usually develop everything in rascript and only create code notes at the end. During this process, I use RATools' achievement view to see which addresses are still missing notes. The view didn't support offset notes for pointers though, so it was breaking my workflow :)
RATools was already parsing offset notes, so this PR is just displaying that information on the requirements view. The idea is to keep track of a parent code note as we go through the requirements. AddAddress sets the parent note and chained conditions resolve their code notes using the parent note's offset notes.