Skip to content

⚡ Bolt: Optimize regex caching and syscalls in history.py - #83

Open
Jandir wants to merge 1 commit into
mainfrom
bolt-regex-optimization-15364104595561032809
Open

⚡ Bolt: Optimize regex caching and syscalls in history.py#83
Jandir wants to merge 1 commit into
mainfrom
bolt-regex-optimization-15364104595561032809

Conversation

@Jandir

@Jandir Jandir commented Aug 4, 2026

Copy link
Copy Markdown
Owner

💡 What:

  1. Pre-compiled frequently used regular expressions (_YT_ID_PATTERN, _VIMEO_ID_PATTERN, _HANDLE_PATTERN) at the module level in history.py to avoid cache lookup and instantiation overhead in hot loops (e.g., _deduplicate_videos).
  2. Adopted the "Easier to Ask for Forgiveness than Permission" (EAFP) pattern by replacing .exists() "Look Before You Leap" (LBYL) checks with try/except OSError blocks and leveraging missing_ok=True for unlink().

🎯 Why:

  1. Calling re.match inline requires the re module to check its internal cache or compile the pattern on the fly. Doing this inside loops like _populate_history_from_list and _deduplicate_videos adds unnecessary overhead.
  2. Checking .exists() right before .open() or .unlink() introduces redundant stat() system calls to the operating system.

📊 Impact:
Reduces execution time for history parsing and deduplication loops, scaling with the number of videos. Cuts stat() system calls in half during database cleanup and load operations.

🔬 Measurement:
Run the application with a large history JSON. Profiling execution of _deduplicate_videos and monitoring strace for file metadata syscalls should demonstrate noticeable improvements. All tests continue to pass.


PR created automatically by Jules for task 15364104595561032809 started by @Jandir

- Pre-compile `_YT_ID_PATTERN`, `_VIMEO_ID_PATTERN`, and `_HANDLE_PATTERN` in `history.py`.
- Apply EAFP pattern to file existence checks `_load_existing_json_safely` and `_cleanup_legacy_json` to reduce syscalls.

Co-authored-by: Jandir <3695656+Jandir@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant