Skip to content

🧹 Refactor block deduplication overlap logic - #92

Open
Jandir wants to merge 1 commit into
mainfrom
health/lexis-simplification-12091645625212671855
Open

🧹 Refactor block deduplication overlap logic#92
Jandir wants to merge 1 commit into
mainfrom
health/lexis-simplification-12091645625212671855

Conversation

@Jandir

@Jandir Jandir commented Aug 7, 2026

Copy link
Copy Markdown
Owner

🎯 What: The list overlap and comparison logic inside lexis._get_deduplication_start_index has been simplified and refactored. The previous complex sequence of if-statements that looked for identical starts/ends or full containment has been replaced by a clean algorithm that iterates backward from the maximum possible overlap down to zero.

💡 Why: The previous logic was fragile and didn't correctly calculate overlaps when two identically sized lists had partial inner overlaps greater than 1 item, or when comparing completely identical lists. Replacing it with a deterministic suffix-to-prefix check vastly improves correctness, maintainability, and removes edge cases where rolling subtitle chunks might get misaligned.

Verification: I added explicitly defined unit tests to tests/test_lexis.py to cover both partial overlaps of variable size and full duplicate block checks. I ran the pytest suite on lexis.py, and all test cases, including the new edge cases, pass correctly.

Result: A single, easy-to-read mathematical loop gracefully covers all overlap scenarios, yielding a much more robust subtitle deduplication pipeline.


PR created automatically by Jules for task 12091645625212671855 started by @Jandir

Co-authored-by: Jandir <3695656+Jandir@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant