🧹 [Code Health] Centralize duplicated download_video code into common utility - #94
🧹 [Code Health] Centralize duplicated download_video code into common utility#94Jandir wants to merge 1 commit into
Conversation
Co-authored-by: Jandir <3695656+Jandir@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The code health issue addressed is the massively duplicated logic for yt-dlp
download_videoorchestrator invimeo.pyandyoutube.py.💡 Why: Duplicated logic spanning over hundreds of lines of code is prone to bugs and makes updates harder. Centralizing extraction flow, smart language mapping, progress hooks, HTTP 429 auto-healing, and cookie refreshes into a single utility file (
dl_common.py) significantly streamlines and declutters both platform-specific modules. This leads to cleaner, drier, and more maintainable architecture.✅ Verification: Verified by ensuring the exact behavior, argument mapping, and edge-case behaviors mapped identically to the previous version and confirming that
pytest tests/successfully passed all 92 unit tests in less than three seconds.✨ Result: Both
vimeo.pyandyoutube.pynow feature a lightweight wrapper around the core downloader logic, preserving functionality while discarding over 400+ redundant lines of boilerplate code.PR created automatically by Jules for task 2635602496290024089 started by @Jandir