Conversation
| ;; (s/fdef graphql-query-params | ||
| ;; :args (s/cat :params (s/spec ::v1/params)) | ||
| ;; :ret string?) | ||
|
|
There was a problem hiding this comment.
I disabled the specs for graphql-query-params and graphql-bound-query-params for now, because they take now the conformed spec params (a vector with the spec tags). See my comments at the TODOs.
| #_(is (= (q/graphql-query '(nodes {?ids [ID!!]} [:id :__typename])) | ||
| "query nodes ($ids: [ID!]!) { nodes (ids: $ids) { id __typename } }")) | ||
| #_(is (= (q/graphql-query '(nodes {?ids (ID!)} [:id :__typename])) | ||
| "query nodes ($ids: [ID!]!) { nodes (ids: $ids) { id __typename } }"))) |
There was a problem hiding this comment.
GraphQL has also the notion of not nullable lists, like [Int!]! for example. Not sure what's the best syntax to use here. I had those 2 ideas, either a double !! in the inner type. We could use a list instead of a vector meaning not nullable, or maybe a set? I don't like any of those too much. Do you have another idea?
|
|
||
| (s/fdef graphql-bound-mutation-params | ||
| :args (s/cat :params (s/spec ::groom.specs.v1/mutation-call-params)) |
There was a problem hiding this comment.
I think the queries and mutations namespaces are perfect candidates for cljc. When converting them to cljc I noticed that the double colon in front of ::groom.specs.v1/mutation-call-params fails in clojure, but not in clojurescript. I choose to use the alias instead of the fully qualified keywords, because I think the we will use the v1 namespace quite often here and in the queries namespace.
| [org.clojure/test.check "0.10.0-alpha2"] | ||
| [sablono "0.8.3"]] | ||
| :source-paths ["src/main"] | ||
| :test-paths ["src/test"]) |
There was a problem hiding this comment.
We can remove the project.clj if you want, I just wanted to get a REPL going and wasn't sure what the plan was regarding boot or deps.edn.
1 participant
No description provided.