Conversation
…BA move based on payment date
…f module account_move_name_sequence is installed
…sk#31944 Date each cash basis entry with the payment date of its own partial reconcile instead of the first partial of the batch, and consider the tax lock date in addition to the user fiscal lock date. When the payment date falls in a locked period the behavior is now configurable per company (default: block the reconciliation with an explanatory error; alternatives: date the entry on the first open day or keep the standard behavior). Add settings UI, tests and readme. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Bump manifest version to 19.0.1.0.0 - account.partial.reconcile: pass the journal to company._get_user_fiscal_lock_date() (new signature) and replace the removed company.max_tax_lock_date with company.user_tax_lock_date - Use self.env._() instead of odoo._ for translations - Write the CABA move date with skip_readonly_check context: since 19.0 the date of a posted move is readonly in account.move.write() - Tests: setUpClass() without chart_template_ref (removed in 18.0) and account.account company_ids m2m instead of company_id - Strip trailing whitespace in README.rst (doc8)
Available types: 'task#', 't#' (case insensitive) Examples:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of the Jarsa custom module
account_caba_payment_datefrom 17.0 to 19.0.Ported the full 17.0 history (7 commits) and adapted to 19.0:
19.0.1.0.0.company._get_user_fiscal_lock_date()now requires the journal argument; passmove.journal_id.company.max_tax_lock_datewas removed in 18.0+; replaced withcompany.user_tax_lock_date.self.env._()(prefer-env-translation).dateof a posted move is readonly inaccount.move.write(); the internal controlled write of the CABA move date now uses theskip_readonly_checkcontext (same mechanism the core uses).setUpClass()withoutchart_template_refandaccount.account.company_ids(m2m) instead ofcompany_id.Quality:
pre-commit-vauxooscoped to the module: Mandatory Passed, Optional Passed (pre-existing failures in other modules of the 19.0 branch are untouched).Task: Starka migration 17.0 -> 19.0.