feat: Add configurable WCF binding timeouts for ONVIF clients#54
Open
TWhidden wants to merge 5 commits intoJazea:masterfrom
Open
feat: Add configurable WCF binding timeouts for ONVIF clients#54TWhidden wants to merge 5 commits intoJazea:masterfrom
TWhidden wants to merge 5 commits intoJazea:masterfrom
Conversation
added 5 commits
October 24, 2025 10:57
…nd OnvifClientFactory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Purpose
Add support for configurable WCF binding timeouts in the ONVIF client factory to enable faster failure detection and better control over network operation timeouts.
Problem
WCF bindings use 1-minute default timeouts for connection operations, which can cause long delays when cameras are unreachable or unresponsive. Applications need the ability to override these timeouts for faster failure handling.
Solution
Introduced
OnvifBindingTimeoutConfigurationclass with four nullable timeout properties:OpenTimeout- Connection establishment timeoutSendTimeout- Request transmission timeoutReceiveTimeout- Response reception timeoutCloseTimeout- Connection closure timeoutConfiguration is opt-in via
OnvifClientFactory.BindingTimeoutConfigstatic property. Null values preserve WCF defaults, ensuring backward compatibility.Changes
OnvifBindingTimeoutConfiguration.cs- New configuration class with nullable timeout propertiesOnvifClientFactory.cs- AddedBindingTimeoutConfigstatic property and timeout application logicBackward Compatibility
✅ Fully backward compatible - library behavior unchanged unless
BindingTimeoutConfigis explicitly setUsage Example
Override all default WCF timeouts:
Enabled
#nullablefor specific class files only, as enabling it in the .csproj would generate over 1,000 warnings due to generated code requiring significant refactoring to support nullable annotations.