Fix discover exception due to race condition#61
Open
sak1ein-keen wants to merge 1 commit intoJazea:masterfrom
Open
Fix discover exception due to race condition#61sak1ein-keen wants to merge 1 commit intoJazea:masterfrom
sak1ein-keen wants to merge 1 commit intoJazea:masterfrom
Conversation
when the timeout occures, finally block disposes the UDP client while pending ReceiveAsync operation. This leads to race condition where socket is disposed while the receive operation is still trying to complete, resulting in ObjectDisposedException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the timeout occurs, finally block disposes the UDP client while pending ReceiveAsync operation. This leads to race condition where socket is disposed while the receive operation is still trying to complete, resulting in ObjectDisposedException.
`
An exception occured: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Sockets.Socket'
at System.Net.Sockets.UdpClient.EndReceiveFrom(IAsyncResult asyncResult, IPEndPoint& endPoint)
at System.Net.Sockets.UdpClient.EndReceive(IAsyncResult asyncResult, IPEndPoint& remoteEP)
at System.Net.Sockets.UdpClient.b__64_1(IAsyncResult ar)
at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServiers.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Onvif.Core.Discovery.Common.UdpClientWrapper.d__11.MoveNext()
`