fix: 랜딩 페이지 XSS 취약점 수정 - #17
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showResp,showErr: API 응답/에러 메시지를innerHTML대신textContent로 삽입updateRL: 로봇 이름을createElement+textContent로 DOM 직접 구성 (Stored XSS 경로 차단)취약점 설명
서버 DB에 악성 이름(
<img src=x onerror=...>)이 등록된 경우, 랜딩 페이지 로드 시/demo/robots응답을innerHTML로 렌더링해 스크립트가 실행되는 Stored XSS 가능성 존재.Test plan
<script>alert(1)</script>포함 이름으로 로봇 등록 후 페이지 로드 시 실행 안 됨 확인🤖 Generated with Claude Code