ci: consolidate pr-review workflows to the managed smart layout#37
Conversation
There was a problem hiding this comment.
Approach Review: The approach of consolidating the split PR review workflows into a single file with job-level conditionals is solid. It reduces workflow file clutter and keeps related review tasks grouped together. Given that this is rendered from a template (j4k-align), it also centralizes the configuration management. The approach looks good.
Approach review by Approach Review 2 (gemini-3.1-pro-preview)
There was a problem hiding this comment.
Approach Review: Approach looks good. Consolidating the two near-identical wrapper workflows (pr-review-on-open / pr-review-on-push) into a single file with separate approach and code jobs is a straightforward CI cleanup with equivalent trade-offs. The previous split existed only to attach different triggers to different recipe sets; merging them into one file while gating the approach job with if: github.event.action == 'opened' preserves that behavior without duplication. No standard library, existing codebase utility, or better-known pattern applies to GitHub Actions YAML consolidation, and the change is not more complex than necessary.
Approach review by Approach Review 3 (OpenCode Wafer) (GLM-5.2)
Replaces the split pr-review-on-open/push workflows (whose recipe ids were removed from the recipe server) with the managed single-file smart layout rendered from the j4k-align template.