fix: add managed release config disabling success comments#24
Merged
Conversation
semantic-release previously ran on pure defaults; the default @semantic-release/github success step comments on every #N reference found in commit messages and fails the release run when a number does not resolve to a real issue (e.g. a regex example in a commit body). Synced from j4k-align #28.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
release.config.mjsnow managed by j4k-align (Jercik/j4k-align#28) for npm-publishing package repos.Previously semantic-release ran on pure defaults here. The default
@semantic-release/githubsuccess step parses#Nreferences in released commit messages and comments on each — and fails the whole release run when a number doesn't resolve to a real issue (seen on repoq v1.0.5, where a commit body quoting"#123"as a regex example 404'd after the npm publish had already succeeded).successCommentCondition: falseskips the commenting flow entirely; the plugin list otherwise matches semantic-release's defaults.