ci: sync pr-review workflow to smart review recipes#28
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approach Review: The meaningful change here is swapping the recipe IDs (the old ones were removed from the recipe server, so the new *-smart IDs are required — no alternative there).
The structural change is removing the YAML anchors (&review-permissions / *review-permissions, etc.) in favor of duplicated permission/secret blocks across the approach and code jobs. In a hand-maintained workflow I'd flag this — anchors are the standard DRY mechanism for reused blocks, and duplication means future permission changes must be applied to every job in lockstep.
But the PR description notes this file is rendered from the j4k-align template, so the duplication is generated, not hand-edited. For a templated workflow the trade-off reverses: anchors add parse/emit friction for the generator, while duplicated blocks are trivially regenerated on each render. Given that, the duplicated-YAML approach is reasonable here.
approach looks good.
Approach review by Approach Review 3 (OpenCode Wafer) (GLM-5.2)
1 participant
Syncs the managed pr-review workflow to the smart review recipes; the previous recipe ids were removed from the recipe server, which failed this repo's review CI. Rendered from the fixed j4k-align template.