feat(clean): dry-run preview 출력 연결#78
Merged
Merged
Conversation
clean dry-run 경로에서 core clean preview excerpt를 사용해 삭제 대상별 상태와 미리보기를 출력합니다. threshold skipped 대상과 unavailable 대상을 별도 섹션으로 분리하고 apply 삭제 흐름은 유지합니다. Closes #73
Owner
Author
|
독립 fresh-session 리뷰 결과
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
kratos cleandry-run은 삭제 후보 파일명 중심으로만 보여주고, core에 이미 있는 clean preview excerpt와 unavailable/threshold 정보를 CLI에 충분히 노출하지 못했습니다.변경 사항
build_clean_preview를 사용하도록 연결했습니다.--apply실제 삭제 경로는 기존clean_from_report_with_min_confidence흐름을 유지했습니다.검증
rustfmt --check crates/kratos-cli/src/commands/clean.rs crates/kratos-cli/tests/clean_threshold_cli.rs crates/kratos-cli/tests/cli_smoke.rsgit diff --checkcargo test -p kratos-core --test clean_previewcargo test -p kratos-cli --test clean_threshold_clicargo test -p kratos-cli --test cli_smokeCritical 0 / High 0 / Medium 0 / Low 0참고: 전체
cargo fmt --check는 시도했지만, 이번 lane 범위 밖의 기존 core 파일 formatting drift 때문에 실패했습니다. 범위 밖 파일을 rewrite하지 않기 위해 touched 파일만 별도rustfmt --check로 확인했습니다.브랜치 / 워크트리
origin/masterfeat/73-clean-preview/private/tmp/kratos-issue-73이슈 연결
Closes #73