feat(scan): no-write 출력 제어 추가#79
Merged
Merged
Conversation
scan에 --no-write 경로를 추가해 기본 리포트 파일을 생성하지 않고 human summary를 출력하게 했습니다. JSON stdout 순수성, --output 병용 거부, 기본 .kratos 쓰기 안내와 npx next step 안내를 테스트로 고정했습니다. Closes #75
Owner
Author
|
독립 fresh-session 리뷰 결과
검증 확인:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
kratos scan기본 실행이.kratos/latest-report.json을 생성해 checkout을 dirty하게 만들 수 있고, npx 실행자에게 다음 단계 명령이kratos ...형태로만 보여 copy-paste UX가 애매했습니다.변경 사항
scan에--no-write옵션을 추가해 human summary를 출력하면서.kratos/와latest-report.json을 만들지 않도록 했습니다.--output과--no-write병용은 config error로 거부합니다.--jsonstdout은 안내 문구 없이 JSON만 유지되며,--json --no-write도 report 파일을 만들지 않습니다..kratos/latest-report.json저장 경로 사용 시 checkout dirty 가능성과.gitignore,--output,--no-write대안을 안내합니다.npx @jeremyfellaz/kratos ...대체 명령을 함께 노출합니다.검증
rustfmt --check crates/kratos-cli/src/commands/mod.rs crates/kratos-cli/src/commands/scan.rs crates/kratos-cli/tests/cli_smoke.rsgit diff --checkcargo test -p kratos-cli --test cli_smokecargo run -p kratos-cli -- scan /private/tmp/kratos-no-write-smoke.GEvceH/demo-app --no-writetest ! -e /private/tmp/kratos-no-write-smoke.GEvceH/demo-app/.kratos/latest-report.jsontest ! -e /private/tmp/kratos-no-write-smoke.GEvceH/demo-app/.kratoscargo test --workspacenpm testnpm pack --dry-run --cache /private/tmp/kratos-npm-cache.YfPsIr리뷰 게이트
브랜치 / 워크트리
masterfeat/75-scan-no-write/private/tmp/kratos-issue-75이슈 연결
Closes #75