build: Rust crate publish 비활성화#108
Merged
Merged
Conversation
Owner
Author
|
독립 fresh-session 리뷰 결과
Note: GitHub 정책상 self-authored PR에는 official approve review를 제출할 수 없어 동일한 verdict를 PR comment로 남깁니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
v1.0.0 npm 정식 출시에서 Rust workspace crate가 별도 crates.io 공개 API처럼 보이지 않도록 공개 정책을 manifest에 고정합니다.
변경 사항
legolas-clicrate에publish = false를 추가했습니다.legolas-corecrate에publish = false를 추가했습니다.검증
cargo metadata --format-version 1cargo test --workspacegit diff --check$devils-advocate-review-loopRound 1: Critical 0 / High 0 / Medium 0 / Low 0브랜치 / 워크트리
feature/v1-rust-crate-publish-policy/Users/pjw/workspace/legolas/.worktrees/feature-v1-rust-crate-publish-policy이슈 연결
Closes #103
Refs #102