fix(tsconfig): node_modules exclude 노이즈 완화#108
Merged
Conversation
TypeScript 기본 exclude 디렉터리와 동일한 node_modules/bower_components/jspm_packages no-op exclude는 기본 audit finding에서 제외합니다. 비기본 exclude no-op finding과 empty include warning은 기존 계약대로 유지하고 regression test로 고정했습니다. Closes #105
Owner
Author
|
독립 fresh-session 리뷰 결과
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
exclude: ["node_modules"]는 TypeScript 기본 exclude와 동일한 관용 설정인데, 기존 audit은 이 값을 no-op excludeInfofinding으로 보여 줬습니다. 이로 인해 실제 조치가 필요한 tsconfig finding과 관용 설정 noise가 섞였습니다.변경 사항
node_modules,bower_components,jspm_packages와 동일한 exclude 패턴은 no-op exclude finding에서 제외했습니다.generated/**/*.ts처럼 TypeScript 기본 exclude가 아닌 no-op exclude는 기존Infofinding을 유지했습니다.검증
cargo test -p maximus-checks --test tsconfig_checkscargo test -p maximus-cli --test mvp_paritygit diff --checkrustfmt --check crates/maximus-checks/src/tsconfig.rs crates/maximus-checks/tests/tsconfig_checks.rs브랜치 / 워크트리
mastercodex/fix-105-tsconfig-node-modules-noise/private/tmp/maximus-audit-signal-wave1-20260505/issue-105-tsconfig-node-modules-noise이슈 연결
Closes #105