You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That's a throwaway PR (base: issue-158-audit-freeze, my open PR for
this issue — wraith-protocol#183) that temporarily activated the freeze window and
touched stellar/stealth-announcer/README.md, an in-scope path.
Without the audit-approved label: Audit Freeze Gate failed.
After adding the label: the same check passed on the same commit.
Not merged — it was only ever meant to trigger the gate for real. The
freeze activation was reverted on my feature branch afterward.
On the design point about a PR being able to edit its own freeze
window: I used both approaches you mentioned, not just one. Primary —
the workflow checks out the PR's base ref (not the default PR-merge
ref), and check.ts separately fetches ENGAGEMENT.md's content from
that same base SHA via the GitHub API, so a PR's edits to that file are
simply invisible to the check. Secondary (defense in depth) — ENGAGEMENT.md is always treated as a frozen path in its own right
whenever a freeze is active, regardless of what freeze_paths lists, so
even if the first mechanism ever regressed, editing the file would still
require the label. Full writeup in scripts/audit-freeze/README.md on wraith-protocol#183.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.